Re: [patch] i386: use C code for current_thread_info()

From: Linus Torvalds
Date: Sun Jun 11 2006 - 15:36:33 EST




On Sun, 11 Jun 2006, Chuck Ebbert wrote:
>
> Using C code for current_thread_info() lets the compiler optimize it.

Ok, me likee. I just worry that this might break some older gcc version.
Have you checked with gcc-3.2 or something?

We've had that "current_stack_pointer" thing for a long while, but we only
use it in the irq-stack path (where it's really very incidental: the whole
use of the "previous_esp" thing is only for the oops tracing. Maybe there
was some reason (like gcc generating bad code) for not using it earlier?

(Admittedly, a more likely reason is probably just nobody looking at it,
but it sounds like we should check it out anyway, just in case)

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/