Re: [SPARSEMEM] confusing uses of SPARSEM_EXTREME (try #2)

From: Andy Whitcroft
Date: Mon Jun 12 2006 - 12:24:27 EST


Franck Bui-Huu wrote:
> Is it me or the use of CONFIG_SPARSEMEM_EXTREME is really confusing in
> mm/sparce.c ? Shouldn't we use CONFIG_SPARSEMEM_STATIC instead like
> the following patch suggests ?
>
> -- >8 --
> Subject: [PATCH] Remove confusing uses of SPARSEMEM_EXTREME
>
> CONFIG_SPARSEMEM_EXTREME is used in sparce.c whereas
> CONFIG_SPARSEMEM_STATIC seems to be more appropriate.
>
> Signed-off-by: Franck Bui-Huu <vagabon.xyz@xxxxxxxxx>

In my mind the positive option is selecting for code supporting EXTREME
so it seems to make sense to use that option. Perhaps the confusion
comes from a lack of comments there to say that the else case is STATIC.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/