Re: [PATCH] revert "swsusp: fix breakage with swap on lvm"

From: Rafael J. Wysocki
Date: Mon Jun 12 2006 - 16:36:26 EST


On Monday 12 June 2006 14:25, Dave Jones wrote:
> On Mon, Jun 12, 2006 at 12:21:13PM +0200, Rafael J. Wysocki wrote:
>
> > > So, now I'm getting bug reports from users about .17rc breaking
> > > their resume again. (https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194784)
> > >
> > > If this was a temporary thing, what should we be doing to keep
> > > old installations working ?
> >
> > This was temporary, because the handling of it has been moved to
> > kernel/power/swap.c and mm/swapfile.c now, but the code has not changed much
> > (surely it doesn't return -ENODEV if swsusp_resume_device is not set).
> > Moreover, the new code has been in -rc since 2.6.17-rc1.
> >
> > The report you are referring to is for the kernel called 2.6.16-1.2255_FC6.
> > Is this just 2.6.17-rc* renamed or is it related to -rc in another way?
>
> Yes, it's .17rc6.
> (They only become a 2.6.17-x after .17 is final)

Clear.

Well, I need some more information.

I don't think the breakage has been caused by any of my patches this time, so
I'll have to figure out what else might have caused it. [The problem is last
significant changes in swsusp that might be related to this were commited
a couple of months ago. ;-) ]

Greetings,
Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/