Re: [RFC] Slimming down struct inode

From: Avi Kivity
Date: Tue Jun 13 2006 - 14:08:48 EST


Theodore Tso wrote:

On Tue, Jun 13, 2006 at 05:00:59PM +0300, Avi Kivity wrote:
>
> It can be made into an inode operation:
>
> if (inode->i_ops->getblksize)
> return inode->i_ops->getblksize(inode);
> else
> return inode->i_sb->s_blksize;
>
> Trading some efficiency for space.

Yep, that was what I was planning on doing....


Maybe

if (inode->i_sb->s_blksize)
return inode->i_sb->s_blksize;
else
...

is a tiny little bit faster...

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/