Re: [RFC][PATCH] binfmt: turn MAX_ARG_PAGES into a sysctl tunable

[Peter Zijlstra]

On Wed, 2006-06-14 at 08:53 -0700, Arjan van de Ven wrote:
> Peter Zijlstra wrote:
> > From: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> > 
> > Some folks find 128KB of env+arg space too little. Solaris provides them with
> > 1MB. Manually changing MAX_ARG_PAGES worked for them so far, however they
> > would like to run the supported vendor kernel.
> 
> then this patch should go to the vendors maybe ;)

You know it comes from one :-)

But as Randy said, there is interrest to not deviate too much and esp.
wrt. interfaces.

> > 
> > In the interrest of not penalizing everybody with the overhead of just
> > setting it larger, provide a sysctl to change it.
> > 
> 
> why not go all the way and make it truely dynamic ?

Looking at the code again even this change feels heavy, making it
dynamic would only bloat it more.

If you really think we'll gain anything by having this dynamic please
tell me and I'll make an honest effort, but for now I'd like to stick
with this approach.

Peter

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/