Re: [UBUNTU:acpi/ec] Use semaphore instead of spinlock

From: Arjan van de Ven
Date: Thu Jun 15 2006 - 20:54:48 EST


On Wed, 2006-06-14 at 18:14 -0700, Randy Dunlap wrote:
> updated version:
>
> From: Ben Collins <bcollins@xxxxxxxxxx>
>
> [UBUNTU:acpi/ec] Use semaphore instead of spinlock to get rid of missed
> interrupts on ACPI EC (embedded controller)


that is odd.

first of all this should use a mutex not a semaphore.

Second, if this isn't used in irq context, then just dropping the
"_irqsave" from the spinlocks should be enough to actually get rid of
the missed interrupts.... and if it is used there then I highly question
your use of semaphores etc...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/