Re: [PATCH] no_pci_serial

From: Russell King
Date: Fri Jun 16 2006 - 15:31:45 EST


On Fri, Jun 16, 2006 at 03:21:08PM +0000, Milan Svoboda wrote:
> This patch allows to compile 8250 driver on systems without pci bus.

inb/outb/readb/writeb methods have nothing to do with the presence of
a PCI bus or not, so the patch is wrong - and it actually breaks a lot
of machine implementations which use this.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/