Re: tg3 timeouts with 2.6.17-rc6
From: Michael Chan
Date: Sat Jun 17 2006 - 14:21:38 EST
On Fri, 2006-06-16 at 20:37 -0700, Michael Chan wrote:
> David Miller wrote:
>
> > From: "Michael Chan" <mchan@xxxxxxxxxxxx>
> > Date: Fri, 16 Jun 2006 18:27:32 -0700
> >
> > > In the meantime, I wonder if we should disable TSO by default on the
> > > 5780 chip for 2.6.17.
> >
> > Sounds reasonable. Would we disable it for all chips that set
> > TG3_FLG2_5780_CLASS or a specific variant?
> >
> Yes, let's disable it for all TG3_FLG2_5780_CLASS chips for now
> until we figure out what's going on.
David, Here's the patch if you haven't already made one:
[TG3]: Disable TSO by default on 5780 class chips.
Disable TSO by default on 5780, 5714, and 5715 chips for now while we
investigate the reported tx timeouts by Juergen Kreileder. Thanks to
Juergen for reporting the problem.
Update version to 3.60.
Signed-off-by: Michael Chan <mchan@xxxxxxxxxxxx>
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 862c226..607d87e 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -69,8 +69,8 @@
#define DRV_MODULE_NAME "tg3"
#define PFX DRV_MODULE_NAME ": "
-#define DRV_MODULE_VERSION "3.59"
-#define DRV_MODULE_RELDATE "June 8, 2006"
+#define DRV_MODULE_VERSION "3.60"
+#define DRV_MODULE_RELDATE "June 17, 2006"
#define TG3_DEF_MAC_MODE 0
#define TG3_DEF_RX_MODE 0
@@ -11385,7 +11385,11 @@ static int __devinit tg3_init_one(struct
* Firmware TSO on older chips gives lower performance, so it
* is off by default, but can be enabled using ethtool.
*/
- if (tp->tg3_flags2 & TG3_FLG2_HW_TSO)
+ /* Disable TSO by default on all 5780 class chips because
+ * of reported tx timeouts.
+ */
+ if ((tp->tg3_flags2 & TG3_FLG2_HW_TSO) &&
+ !(tp->tg3_flags2 & TG3_FLG2_5780_CLASS))
dev->features |= NETIF_F_TSO;
#endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/