Re: [Alsa-devel] all-modular snd-aoa

From: Takashi Iwai
Date: Fri Jun 23 2006 - 10:49:26 EST


At Fri, 23 Jun 2006 16:36:30 +0200,
Johannes Berg wrote:
>
> On Fri, 2006-06-23 at 16:30 +0200, Takashi Iwai wrote:
>
> > Where is the problem in Makefile? It looks OK to me...
>
> Well, the problem is the fact the snd-aoa/ dir contains nothing to be
> compiled and the kernel Makefiles don't like that.

Then it's eaiser to fix sound/Makefile.

--- a/sound/Makefile Fri Jun 23 15:18:41 2006 +0200
+++ b/sound/Makefile Fri Jun 23 16:49:15 2006 +0200
@@ -4,7 +4,8 @@ obj-$(CONFIG_SOUND) += soundcore.o
obj-$(CONFIG_SOUND) += soundcore.o
obj-$(CONFIG_SOUND_PRIME) += oss/
obj-$(CONFIG_DMASOUND) += oss/
-obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/ aoa/
+obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/
+obj-$(CONFIG_SND_AOA) += aoa/

ifeq ($(CONFIG_SND),y)
obj-y += last.o


> > Nevertheless, aoa/Kconfig has a wrong dependency on SND_PCM.
>
> Good point. Committing to my repository, how should we process things
> like that now? Should I post some patches once a while or do you want to
> commit that right away?

Post patches to alsa-devel (and Cc to me). Will be pushed together
with other fixes.


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/