Re: [PATCH] ieee1394: dv1394: sem2mutex conversion

From: Arjan van de Ven
Date: Sat Jun 24 2006 - 13:41:42 EST


On Sat, 2006-06-24 at 19:37 +0200, Stefan Richter wrote:
>
> - if (down_trylock(&video->sem)) {
> + if (mutex_trylock(&video->mtx)) {

this is a bug!

mutex_trylock follows the spinlock trylock convention, not the semaphore
trylock convention!!!


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/