Re: [PATCH] swsuspend breakage in 2.6.17-git

[Linus Torvalds]

On Sun, 25 Jun 2006, Daniel Ritz wrote:
> 
> commit b6370d96e09944c6e3ae8d5743ca8a8ab1f79f6c:
> 	[PATCH] swsusp: i386 mark special saveable/unsaveable pages
> breaks swsusp for me with a page fault in kernel/power/snapshot.c:save_arch_mem()
> 
> the following patch makes suspend-resume working again, but some
> problems still remain: fan goes on and stays on after resume (same as
> in bug #5000). i guess this is a due to a change in ACPI which i still
> have to track down along with the problem that acpi is not powering-off
> my other laptop anymore...
> 
> comments?

Looking at that whole commit, it looks bogus.

The rule about ACPI memory (whether NVS or not) according to what I have 
seen is that the OS is _not_ supposed to touch that memory except through 
ACPI routines.

So saving and restoring those pages sounds really really wrong in the 
first place. We have no idea what current state it could screw up.

Shaohua?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/