Re: [PATCH] atkbd: restore autorepeat rate after resume

[Dmitry Torokhov]

On 6/26/06, Vojtech Pavlik <vojtech@xxxxxxx> wrote:
> On Mon, Jun 26, 2006 at 10:58:46AM -0400, Dmitry Torokhov wrote:
> > On 6/26/06, Vojtech Pavlik <vojtech@xxxxxxx> wrote:
> > >On Mon, Jun 26, 2006 at 10:35:44AM -0400, Dmitry Torokhov wrote:
> > >> On 6/26/06, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> > >> >From: Linus Torvalds <torvalds@xxxxxxxx>
> > >> >
> > >> >This patch (as728) makes the AT keyboard driver store the current
> > >> >autorepeat rate so that it can be restored properly following a
> > >> >suspend/resume cycle.
> > >> >
> > >>
> > >> Alan,
> > >>
> > >> I think it should be a per-device, not global parameter. Anyway, I'll
> > >> adjust adn apply, thank you.
> > >
> > >You can't make it per-device when there is no device when the keyboard
> > >isn't plugged in. ;)
> >
> > It there is no keyboard then you could not change repeat rate before
> > suspending and we don't have anyhting to restore ;)
>
> What the patch is trying to achieve is that you have the keyboard, set
> the rate, unplug the keyboard, replug the keyboard, get the original
> setting.
>
> In the middle of the process, you have no device to attach the
> information to. That's why the patch uses a global variable.

The original complaint was that we don't keep repeat rate after
suspend/resume cycle. I think pulling the cord and then plugging it
back in is completely different scenario, but even then it will also
work because we do not destroy keyboard device when cord is pulled
(there is no notification that device is gone). So input_dev is still
there and we can use dev->rep[] to restore the former settings.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/