Re: linux-2.6.17.1: undefined reference to `online_page'

[Andy Whitcroft]

Dave Hansen wrote:
> On Mon, 2006-06-26 at 16:39 +0900, Yasunori Goto wrote:
> 
>>===================================================================
>>--- linux-2.6.17.orig/mm/Kconfig        2006-06-26 14:19:11.000000000
>>+0900
>>+++ linux-2.6.17/mm/Kconfig     2006-06-26 14:19:53.000000000 +0900
>>@@ -115,7 +115,7 @@ config SPARSEMEM_EXTREME
>> # eventually, we can have this option just 'select SPARSEMEM'
>> config MEMORY_HOTPLUG
>>        bool "Allow for memory hot-add"
>>-       depends on SPARSEMEM && HOTPLUG && !SOFTWARE_SUSPEND
>>+       depends on SPARSEMEM && HOTPLUG && !SOFTWARE_SUSPEND
>>&& !(X86_32 && !HIGHMEM)
>> 
>> comment "Memory hotplug is currently incompatible with Software
>>Suspend"
>>        depends on SPARSEMEM && HOTPLUG && SOFTWARE_SUSPEND 
> 
> 
> I think it makes a lot more sense to just disable sparsemem when !
> HIGHMEM.  Plus, we can do all of that in the arch-specific Kconfigs and
> not litter the generic ones with this stuff.

SPARSEMEM cirtainly isn't going to offer you anything much with this
little memory.  If you were going to do this I'd say it makes more sense
to introduce an ARCH_DISABLE_MEMORY_HOTPLUG sort of thing and add that
in the x86 Kconfig.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/