Re: [2.6 patch] drivers/mtd/devices/: remove dead _ecc code

From: Adrian Bunk
Date: Tue Jun 27 2006 - 09:09:57 EST


On Thu, Jun 22, 2006 at 12:24:24AM +0200, Thomas Gleixner wrote:
> On Wed, 2006-06-21 at 23:58 +0200, Adrian Bunk wrote:
> > This patch removes some code that is dead code after the
> > "Remove read/write _ecc variants" patch that went into Linus' tree.
>
> Holy cow, are you even remotly knowing what you are doing ?
>
> Removing the xxx_ecc function pointers from the mtd structs does not
> remove the fundamental requirement of ECC for NAND FLASH.
>
> I'm just waiting for the follow up patches which remove nand_ecc and the
> reed solomon library.
>...

nand_ecc isn't dead code.

But if I do understand correctly, you have pending patches to let the
code your patch made dead code and my patch would have removed be used
again?

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/