Re: [PATCH] Restore set_nmi_callback export on x86_64

From: Andi Kleen
Date: Tue Jun 27 2006 - 11:49:37 EST


On Tuesday 27 June 2006 17:24, Jean Delvare wrote:
> Commit 2ee60e17896c65da1df5780d3196c050bccb7d10 broke modular
> oprofile (amongst others I suspect) on x86_64 by killing the
> exports of set_nmi_callback and unset_nmi_callback. Let's
> restore the exports next to the functions as is prefered now.

Hmm yes this happened because I got unsubmitted patches
that remove set_nmi_callback/unset_nmi_callback

But for 2.6.18 the patch is good, thanks.

-Andi

>
> Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> Cc: Andi Kleen <ak@xxxxxxx>
> ---
> arch/x86_64/kernel/nmi.c | 2 ++
> 1 files changed, 2 insertions(+)
>
> --- linux-2.6.17-git.orig/arch/x86_64/kernel/nmi.c 2006-06-27 16:22:17.000000000 +0200
> +++ linux-2.6.17-git/arch/x86_64/kernel/nmi.c 2006-06-27 17:08:18.000000000 +0200
> @@ -607,11 +607,13 @@
> vmalloc_sync_all();
> rcu_assign_pointer(nmi_callback, callback);
> }
> +EXPORT_SYMBOL_GPL(set_nmi_callback);
>
> void unset_nmi_callback(void)
> {
> nmi_callback = dummy_nmi_callback;
> }
> +EXPORT_SYMBOL_GPL(unset_nmi_callback);
>
> #ifdef CONFIG_SYSCTL
>
>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/