Re: [PATCH] move MAX_NR_CONSOLES from tty.h to vt.h

From: Randy.Dunlap
Date: Tue Jun 27 2006 - 15:46:10 EST


On Tue, 27 Jun 2006 15:03:50 -0400 Jon Smirl wrote:

> MAX_NR_CONSOLES is more of a function of the VT layer than the TTY
> one. Moving this to vt.h allows all of the framebuffer drivers to
> remove their dependency on tty.h. Note that console drivers in
> video/console still depend on tty.h but fbdev drivers should not
> depend on the tty layer.
>
> Signed-off-by: Jon Smirl <jonsmir@xxxxxxxxx>

BTW, what are these other 2 added #includes about?

> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 4fd2a27..608fba0 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -15,13 +15,13 @@ #include <linux/kernel.h>
> #include <linux/errno.h>
> #include <linux/string.h>
> #include <linux/mm.h>
> -#include <linux/tty.h>
> #include <linux/slab.h>
> #include <linux/delay.h>
> #include <linux/fb.h>
> #include <linux/ioport.h>
> #include <linux/init.h>
> #include <linux/platform_device.h>
> +#include <linux/screen_info.h>
>
> #include <asm/io.h>
> #include <video/vga.h>
> diff --git a/include/linux/console_struct.h b/include/linux/console_struct.h
> index f8e5587..25423f7 100644
> --- a/include/linux/console_struct.h
> +++ b/include/linux/console_struct.h
> @@ -9,6 +9,7 @@
> * to achieve effects such as fast scrolling by changing the origin.
> */
>
> +#include <linux/wait.h>
> #include <linux/vt.h>
>
> struct vt_struct;

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/