Re: [git pull] Input update for 2.6.17

From: Jeff Garzik
Date: Wed Jun 28 2006 - 03:02:14 EST


Linus Torvalds wrote:
Anyway, "urb->transfer_buffer" was initialized with

urb->transfer_buffer = skb->data;

and I'm pretty damn sure you're supposed to just kfree() it.

eh? I would think dev_kfree_skb(), because who knows whether the skb was cloned, split, data buffer adjusted, destructors need to be called...

kfree()ing skb->data sounds like a recipe for corruption and crashes...

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/