Re: tty_mutex and tty_old_pgrp

[Jon Smirl]

On 6/28/06, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> Ar Mer, 2006-06-28 am 13:36 -0400, ysgrifennodd Jon Smirl:
> > This selinux code is checking to see if the current process still has
> > access rights to it's controlling tty, right? If it doesn't tty and
> > tty_old_pgrp are nulled out. Does this need locking?
>
> Yes that looks like it needs to the tty lock covering it.
I can add the lock.

If the task is the session leader and you null out it's controlling
tty, what about other tasks in the session? I didn't think is was
legal to have some tasks in a session with tty set and some without
it.  Should this turn into a disassociate_tty()?

--
Jon Smirl
jonsmirl@xxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/