Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPathon PowerPC 970 systems

From: Dave Olson
Date: Thu Jun 29 2006 - 20:27:56 EST


On Thu, 29 Jun 2006, David Miller wrote:

| From: Bryan O'Sullivan <bos@xxxxxxxxxxxxx>
| Date: Thu, 29 Jun 2006 14:41:29 -0700
|
| > ipath_core-$(CONFIG_X86_64) += ipath_wc_x86_64.o
| > +ipath_core-$(CONFIG_PPC64) += ipath_wc_ppc64.o
|
| Again, don't put these kinds of cpu specific functions
| into the infiniband driver. They are potentially globally
| useful, not something only Infiniband might want to do.

The new code simply sets a flag as to whether instruction level
write barriers need to be used or not, it doesn't contain actual
code.

The older file (already accepted) does have some setup code, as well as
code setting flags, due to the fact that Bryan mentioned in his reply,
that this stuff simply doesn't yet exist in a generic form. It's not
clear to me that it can ever be made to exist in a generic form that will
actually work on multiple architectures (or that there are enough users
to be worth trying). We can make the attempt, but so far it's pretty
non-generic, in it's very nature.

Dave Olson
olson@xxxxxxxxxxxx
http://www.unixfolk.com/dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/