Re: [PATCH -mm] ide_end_drive_cmd(): avoid instruction pipelinestall

From: Alan Cox
Date: Fri Jun 30 2006 - 14:03:44 EST


Ar Gwe, 2006-06-30 am 11:00 -0700, ysgrifennodd Andrew Morton:
> I guess because he was profiling for IFU_MEM_STALL, not for wall-time.
>
> > NAK because
> > 1. This is a gcc problem
> > 2. Not everyone is using an intel x86-32 box which has such problems
> > 3. IDE is in life-support mode and the relatives are already planning
> > the flowers.
>
> Well. If the patch breaks anything we can dine on hats for a month. Seems
> pretty inoffensive to me.

Yeah its a do nothing change that has no value. We can equally not apply
it and see no difference. Its make-work that might slow down some
systems.

Send it to the gcc people see if its a case they could/should optimise

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/