Re: ACPI: Device [kobj-name] is not power manageable

From: Andrew Morton
Date: Fri Jun 30 2006 - 20:19:35 EST


"Randy.Dunlap" <rdunlap@xxxxxxxxxxxx> wrote:
>
> Andrew, can you send Linus the typo correction patch for this??
> or should I?

Is OK, I have a couple of post-acpi-merge fixlets queued which I'll be
sending in the next batch.

diff -puN drivers/acpi/acpi_memhotplug.c~acpi-printk-fix drivers/acpi/acpi_memhotplug.c
--- a/drivers/acpi/acpi_memhotplug.c~acpi-printk-fix
+++ a/drivers/acpi/acpi_memhotplug.c
@@ -248,7 +248,7 @@ static int acpi_memory_enable_device(str
num_enabled++;
}
if (!num_enabled) {
- ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "\nadd_memory failed\n"));
+ printk(KERN_ERR PREFIX "add_memory failed\n");
mem_device->state = MEMORY_INVALID_STATE;
return -EINVAL;
}
_


and

--- a/drivers/acpi/bus.c~acpi-identify-which-device-is-not-power-manageable
+++ a/drivers/acpi/bus.c
@@ -192,7 +192,7 @@ int acpi_bus_set_power(acpi_handle handl
/* Make sure this is a valid target state */

if (!device->flags.power_manageable) {
- printk(KERN_DEBUG "Device `[%s]is not power manageable",
+ printk(KERN_DEBUG "Device `[%s]' is not power manageable",
device->kobj.name);
return -ENODEV;
}
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/