Re: 2.6.17-mm6

From: Jeremy Fitzhardinge
Date: Mon Jul 03 2006 - 13:23:47 EST


Sergey Vlasov wrote:
These names are truncated - they should end with two hex digits:

snprintf(device->bus_id, sizeof(device->bus_id), "%s:pcie%02x",
pci_name(parent), get_descriptor_id(port_type, service_type));

Names were truncated at 18 characters, but sizeof(device->bus_id) is 20
currently, so these names should just fit there. I see that snprintf()
was changed recently - maybe there is some off-by-one bug there?

There was for a while, but it should be OK in -mm6. Perhaps there's a stray patch hanging around in this kernel?

J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/