Re: [PATCH 1/2] x86-64 TIF flags for debug regs and io bitmap in ctxsw

From: Stephane Eranian
Date: Tue Jul 04 2006 - 04:26:57 EST


Andi,

On Tue, Jul 04, 2006 at 10:14:30AM +0200, Andi Kleen wrote:
>
> > diff -urNp linux-2.6.17.2.orig/arch/x86_64/ia32/ptrace32.c linux-2.6.17.2-tif/arch/x86_64/ia32/ptrace32.c
> > --- linux-2.6.17.2.orig/arch/x86_64/ia32/ptrace32.c 2006-06-17 18:49:35.000000000 -0700
> > +++ linux-2.6.17.2-tif/arch/x86_64/ia32/ptrace32.c 2006-06-30 09:02:16.000000000 -0700
>
> Added thanks. But I had to fix it up by hand because of conflicts.
> Please submit patches against mainline, not stable.
>
Sorry about that.

> > if (t->flags & _TIF_ABI_PENDING)
> >- t->flags ^= (_TIF_ABI_PENDING | _TIF_IA32);
> >+ t->flags ^= (_TIF_ABI_PENDING | _TIF_IA32 | _TIF_DEBUG);
>
> This xor must be obviously outside the if(). I fixed that up too
> by changing it to an unconditional clear.

Yes, my mistake.

--
-Stephane
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/