Re: [PATCH -mm 1/2] swsusp: clean up browsing of pfns

From: Andrew Morton
Date: Tue Jul 11 2006 - 04:58:26 EST


On Tue, 11 Jul 2006 10:34:15 +0200
Pavel Machek <pavel@xxxxxx> wrote:

> Hi!
>
> > Clean up some loops over pfns for each zone in snapshot.c: reduce the number
> > of additions to perform, rework detection of saveable pages and make the code
> > a bit less difficult to understand, hopefully.
>
> Also remove the BUG_ON() so that you can solve Andrew's monster
> machine problem.

I don't understand your comment. I assume you're adding an explanation for
the removal of:

- BUG_ON(PageReserved(page) && PageNosave(page));

from saveable_page().

But my emt64 test box is oopsing when touching a hole in the memory-map; it
isn't going BUG() (any more than usual ;))

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/