[PATCH -mm] kobject: must_check fixes

From: Randy.Dunlap
Date: Tue Jul 11 2006 - 23:51:04 EST


From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>

Check all __must_check warnings in lib/kobject.c

Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
---
lib/kobject.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletion(-)

--- linux-2618-rc1mm1.orig/lib/kobject.c
+++ linux-2618-rc1mm1/lib/kobject.c
@@ -457,6 +457,7 @@ static struct kobj_type dir_ktype = {
struct kobject *kobject_add_dir(struct kobject *parent, const char *name)
{
struct kobject *k;
+ int ret;

if (!parent)
return NULL;
@@ -468,7 +469,13 @@ struct kobject *kobject_add_dir(struct k
k->parent = parent;
k->ktype = &dir_ktype;
kobject_set_name(k, name);
- kobject_register(k);
+ ret = kobject_register(k);
+ if (ret < 0) {
+ printk(KERN_WARNING "kobject_add_dir: "
+ "kobject_register error: %d\n", ret);
+ kobject_del(k);
+ return NULL;
+ }

return k;
}


---
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/