Re: Random panics seen in 2.6.18-rc1

From: Ingo Molnar
Date: Thu Jul 13 2006 - 04:46:10 EST



* Andrew Morton <akpm@xxxxxxxx> wrote:

> > yeah, i'll fix this. Any suggestions of how to avoid the parameter
> > passing? (without ugly #ifdeffery)
>
> No, I don't see a way apart from inlining __cache_free(), or inlining
> cache_free_alien() into both kfree() and kmem_cache_free(), both of
> which are unattractive.

Arjan has an idea that looks nice to me: passing the nesting level via a
special type that has zero size on non-lockdep. This means that the
current "nesting + 1" arithmetics has to be turned into something like:
lockdep_deeper_nesting(var), and that all explicit uses of '0' have to
become symbolic - the former is acceptable and the later is desirable.
This could possibly also be used to clean up some of the VFS-internal
nesting. Hm?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/