Re: [PATCH] reiserfs: fix handling of device names with /'s in them

[Jeff Mahoney]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bodo Eggert wrote:
> Eric Dumazet <dada1@xxxxxxxxxxxxx> wrote:
>> On Wednesday 12 July 2006 18:42, Jeff Mahoney wrote:
> 
>>>  On systems with block devices containing slashes (virtual dasd, cciss,
>>>  etc), reiserfs will fail to initialize /proc/fs/reiserfs/<dev> due to
>>>  it being interpreted as a subdirectory. The generic block device code
>>>  changes the / to ! for use in the sysfs tree. This patch uses that
>>>  convention.
>>>
>>>  Tested by making dm devices use dm/<number> rather than dm-<number>
>> Your patch handles at most one slash. But the description mentions 'slashes'
>> (ie several slashes)
> 
> Besides that, there is no reason to prevent the user from using many slashes.
> OTOH, I'd prefer propper quoting, but having each driver do this would be
> insane.

The strings aren't user-supplied, they're kernel-internal names of block
devices, supplied by the driver. At present there is no possibility of
more than one slash in the name, and I doubt we'll see any new devices
with one slash in them, never mind more than one.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFEt9l6LPWxlyuTD7IRAgwsAJ9nvPJRnnJsbqukhtJj3T2mjJC1hQCfYYeh
lbTYktc+yglYRmxT/LwPcT4=
=767A
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/