Re: [PATCH for 2.6.18-rc2] [2/8] i386/x86-64: Don't randomize stack top when no randomization personality is set

[Ingo Molnar]

* Andi Kleen <ak@xxxxxxx> wrote:

>  unsigned long arch_align_stack(unsigned long sp)
>  {
> -	if (randomize_va_space)
> +	if (!(current->personality & ADDR_NO_RANDOMIZE) && randomize_va_space)
>  		sp -= get_random_int() % 8192;
>  	return sp & ~0xf;

i'm not opposing this patch at all, but didnt the performance problems 
go away when the 0xf was changed to 0x7f?

looks good otherwise.

Acked-by: Ingo Molnar <mingo@xxxxxxx>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/