Re: Null dereference errors in the kernel

From: Peter Osterlund
Date: Tue Jul 18 2006 - 18:38:45 EST


Dave Jones <davej@xxxxxxxxxx> writes:

> On Mon, Jul 17, 2006 at 08:49:19PM -0700, Thomas Dillig wrote:
>
> > 144 drivers/char/agp/ati-agp.c
> > NULL dereference of variable "ati_generic_private.gatt_pages" in
> > function call (drivers/char/agp/ati-agp.c:ati_free_gatt_pages).
>
> I think this is a false positive.

I don't think so. If the 'entry = kzalloc(...)' fails at line 125, the
code will set tables to NULL and retval to != 0. ati_free_gatt_pages()
will then be called with .gatt_pages == NULL and .num_tables > 0. This
will trigger a NULL pointer dereference in ati_free_gatt_pages().

--
Peter Osterlund - petero2@xxxxxxxxx
http://web.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/