Re: Bug with USB proc_bulk in 2.4 kernel

From: Pete Zaitcev
Date: Tue Jul 18 2006 - 21:31:47 EST


On Tue, 18 Jul 2006 10:04:54 -0700, Benjamin Cherian <benjamin.cherian.kernel@xxxxxxxxx> wrote:

> > Another option would be to change USBDEVFS_BULK to USBDEVFS_SUBMITURB.
> > Did you look at doing that?

> We did that as well. But when you try to reap an URB there is no timeout. So
> if something goes wrong you're stuck waiting for the operation to finish or
> for the user to physically unplug the device.

This can't be right. Surely alarm(2) should work?

> >Of course it's very tempting for me to off-load both
> >the work and the responsibility on you.
>
> All right then. I'll send you a patch that backports the string caching
> mechanism from 2.6 in a few days. Would you be able to test it with the
> 210PU?

Yes, that would be fine.

Although I am starting to think about creating a custom locking
scheme in devio.c after all. It seems like less work.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/