Re: [PATCH 3/3] kconfig/lxdialog: add bluetitle color scheme

[Sam Ravnborg]

On Mon, Jul 24, 2006 at 02:28:24PM +0200, Roman Zippel wrote:
> Hi,
> 
> On Mon, 24 Jul 2006, Sam Ravnborg wrote:
> 
> > +static void set_bluetitle_theme(void)
> > +{
> > +	DLG_MODIFY(title, COLOR_BLUE, COLOR_WHITE,  true);
> > +	DLG_MODIFY(button_label_active, COLOR_BLUE, COLOR_BLUE,   true);
> > +	DLG_MODIFY(searchbox_title,     COLOR_BLUE, COLOR_WHITE,  true);
> > +	DLG_MODIFY(position_indicator,  COLOR_BLUE, COLOR_WHITE,  true);
> > +	DLG_MODIFY(tag,                 COLOR_BLUE, COLOR_WHITE,  true);
> > +	DLG_MODIFY(tag_selected,        COLOR_BLUE, COLOR_BLUE,   true);
> > +	DLG_MODIFY(tag_key,             COLOR_BLUE, COLOR_WHITE,  true);
> > +	DLG_MODIFY(tag_key_selected,    COLOR_BLUE, COLOR_BLUE,   true);
> > +}
> 
> In general I would like to see this one become the default, as yellow on 
> white is really terrible, but this one needs fixing too - blue on blue is 
> not really readable either. :)

I blindly replaced yellow with blue.
New version looks like this:
static void set_bluetitle_theme(void)
{
        DLG_MODIFY(title,   COLOR_BLUE, COLOR_WHITE,  true);
        DLG_MODIFY(tag,     COLOR_BLUE, COLOR_WHITE,  true);
        DLG_MODIFY(tag_key, COLOR_BLUE, COLOR_WHITE,  true);
}

The classic color scheme is quite readable on my display.

I can make bluetitle default but keep classic as an option.
Will try this in next version of the patchset.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/