Re: [Patch] [mm] More driver core fixes for -mm

[Cornelia Huck]

On Tue, 25 Jul 2006 01:08:52 -0700,
Andrew Morton <akpm@xxxxxxxx> wrote:

> Removing symlinks seems like a good idea.  Leaving them around might cause
> a subsequent driver load to fail due to EEXIST (assuming that the caller
> checks error codes, as if).
> 
> I assume you're referring to error paths here?

Yes, that was my reasoning.

> But I made bus_attach_device() convert the positive return value to zero. 
> See
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc1/2.6.18-rc1-mm2/hot-fixes/drivers-base-check-errors-fix.patch.

Missed that, sorry.

> 
> Is there a reason to propagate this irritating "1" back out of
> bus_attach_device() as well?

Probably not. Nobody cares whether the device was bound to a driver or
not.

-- 
Cornelia Huck
Linux for zSeries Developer
Tel.: +49-7031-16-4837, Mail: cornelia.huck@xxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/