Re: vxfs_readdir locking incorrect: add lock_kernel() or remove unlock_kernel()?

From: Valdis . Kletnieks
Date: Tue Jul 25 2006 - 18:23:41 EST


On Mon, 24 Jul 2006 17:20:40 PDT, Andrew Morton said:
> That would appear to imply that nobody has used freevxfs in four years.

Given that...

> I don't see anything in there which needs the locking, apart from perhaps
> f_pos updates. But it's probably best to add the lock_kernel() - this is a
> bugfixing exercise, not a remove-BKL-from-freevxfs exercise.

Should we consider a remove-freevxfs-from-kernel exercise?

Attachment: pgp00000.pgp
Description: PGP signature