Re: [patch] slab: always follow arch requested alignments

From: Pekka J Enberg
Date: Wed Jul 26 2006 - 08:29:08 EST


On Wed, 26 Jul 2006, Christoph Lameter wrote:
> The following patch adds an option SLAB_DEBUG_OVERRIDE to switch off
> debugging if its on by default. S390 would have to set ARCH_KMALLOC_FLAGS
> to SLAB_DEBUG_OVERRIDE. The flag will then be passed in
> kmem_cache_init to kmem_cache_create(). This approach also preserves the
> existing slab behavior for all other archs.

Please read my patch again. The rules are simple: we must disable
debugging if architecture OR caller mandated alignment is greater than
BYTES_PER_WORD. Note: for kmem_cache_init() the caller mandated alignment
_is_ ARCH_KMALLOC_MINALIGN.

My patch takes care of _both_ ARCH_KMALLOC_MINALIGN and
ARCH_SLAB_MINALIGN.

Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/