Re: Require mmap handler for a.out executables

[Christoph Hellwig]

> diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
> index f312103..5638acf 100644
> --- a/fs/binfmt_aout.c
> +++ b/fs/binfmt_aout.c
> @@ -278,6 +278,9 @@ static int load_aout_binary(struct linux
>  		return -ENOEXEC;
>  	}
>  
> +	if (!bprm->file->f_op || !bprm->file->f_op->mmap)
> +		return -ENOEXEC;
> +

These checks need a big comment explanining why they are there, else people
will remove them again by accident.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/