Re: [RFC/RFT] Remove polling timer from i8042

From: Dmitry Torokhov
Date: Fri Jul 28 2006 - 08:55:23 EST


On 7/27/06, Vojtech Pavlik <vojtech@xxxxxxx> wrote:
On Thu, Jul 27, 2006 at 12:29:04AM -0400, Dmitry Torokhov wrote:
> Hi,
>
> OK, I had it in works for quite some time and Dave's talk in Ottawa
> made me finish it ;)

Good work.

However I believe you need to test the AUX IRQ in this case before you
use it, otherwise you'll have a lot of people with non-working keyboards
(the input queue is shared), and probably also non-working PCI cards
(BIOSes like to assign IRQ12 to PCI if no mouse is detected by the
BIOS).


What do you mean by testing AUX IRQ? Use I8042_CMD_AUX_LOOP to see if
interrupt fires off? The new code releases IRQ if it can't find a
working AUX port...

You'll see whether this test is necessary if a lot of people report
problems without i8042.noaux.

That can only be seen after extensive testing on a lot of machines,
though. Fortunately 386's and 486's are more or less extinct now, and
with them a lot of the weirder keyboard controllers.


I think I will forward the patch to Andrew and we will see how bad it
is. It works on couple of boxes here but I don't have a lot of
hardware to test on...

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/