Re: [patch 1/5] Add comments to the PDA structure to annotateoffsets

From: Arjan van de Ven
Date: Fri Jul 28 2006 - 14:41:47 EST


On Fri, 2006-07-28 at 20:41 +0200, Andi Kleen wrote:
> On Friday 28 July 2006 18:03, Arjan van de Ven wrote:
> > Subject: [patch 1/5] Add comments to the PDA structure to annotate offsets
> > From: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
>
> So why exactly do you think these numbers need to be documented?
>
> If there is a reason there should be a comment in the code.
>
> Nobody should use fixed numbers, but always get the current ones
> from asm-offset

the 40 one is a gcc ABI one (same offset as userland); that is
documented in the later patch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/