Re: [patch] x86_64: fix is_at_popf() for compat tasks

From: Andi Kleen
Date: Mon Jul 31 2006 - 04:59:14 EST


On Monday 31 July 2006 09:22, Chuck Ebbert wrote:
> When testing for the REX instruction prefix, first check
> for a 32-bit task because in compat mode the REX prefix is an
> increment instruction.

is_compat_task doesn't actually say that a task is in compat mode
(it refers to the Linux compat layer, not x86-64 compat mode)

A better test would be regs->cs == __USER32_CS, but in theory
there could be other code segments in LDT. I guess that can
be ignored though.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/