Re: + espfix-code-cleanup.patch added to -mm tree
From: Jan Beulich
Date: Tue Aug 01 2006 - 09:35:05 EST
>>> pushl %eax; \ <----
>>> - CFI_ADJUST_CFA_OFFSET 4; \
>>> + lss (%esp), %esp;
>> <---- CFI adjustment here is missing.
>Well, someone used that macro in a .fixup section, where the
>CFI adjustments do not seem to work. But since I don't know
>why this was done (Jan?), I reverted that to my original code and
>added the adjustments now.
The macro in question is UNWIND_ESPFIX_STACK, which is used in exactly
one place (in normal .text). Even more, the macro itself switches to
so it would be rather odd if it was used in a .fixup section by itself.
that FIXUP_ESPFIX_STACK doesn't have any annotations, and hence can
freely be used in .fixup.
>>> FIXUP_ESPFIX_STACK # %eax == %esp
>>> - CFI_ADJUST_CFA_OFFSET -20 # the frame has now moved
>>> + CFI_ADJUST_CFA_OFFSET -20
>> Is this CFI adjustment still correct?
>Hmm, I guess it wasn't correct also before, so I just
>left it as is. Should now be fixed.
I would think it was correct, but surely annotating these pieces of
wasn't something that anybody but the original author (you) should
done, as it wasn't too difficult to get lost.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/