Re: [take2 1/4] kevent: core files.

From: Evgeniy Polyakov
Date: Tue Aug 01 2006 - 10:32:42 EST


On Tue, Aug 01, 2006 at 10:27:36AM -0400, James Morris (jmorris@xxxxxxxxx) wrote:
> > > > + u->ready_num = 0;
> > > > +#ifdef CONFIG_KEVENT_USER_STAT
> > > > + u->wait_num = u->im_num = u->total = 0;
> > > > +#endif
> > >
> > > Generally, #ifdefs in the body of the kernel code are discouraged. Can
> > > you abstract these out as static inlines?
> >
> > Yes, it is possible.
> > I would ask is it needed at all?
>
> Yes, please, it is standard kernel development practice.

Will do.
Thanks, James.

> --
> James Morris
> <jmorris@xxxxxxxxx>

--
Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/