Re: [PATCH] OMAP: I2C driver for TI OMAP boards #2

From: Tony Lindgren
Date: Tue Aug 01 2006 - 10:33:36 EST

* David Brownell <david-b@xxxxxxxxxxx> [060801 02:58]:
> On Monday 31 July 2006 12:10 pm, Russell King wrote:
> > On Mon, Jul 31, 2006 at 09:41:00AM -0700, David Brownell wrote:
> > > On Monday 31 July 2006 9:13 am, Jean Delvare wrote:
> > > > Hi David,
> > > >
> > > > > And I **really** hope this gets merged into 2.6.18 since virtually
> > > > > no OMAP board is very usable without it. I2C is one of the main
> > > > > missing pieces(*) ... can whoever's managing I2C merges please
> > > > > expedite this?
> >
> > Slightly off-topic, and probably not your area, but it would probably
> > help your case if omap were better looked after in mainline.
> Actually that _is_ part of my case. It can't be looked after in any
> reasonable way until the I2C driver gets merged, because significant
> chunks of the OMAP driver stack require I2C. (And notably for me,
> USB always requires I2C to handle VBUS switches ...)
> So for example once the OMAP I2C gets merged, then it'll finallly
> become practical for folk to try _using_ mainline kernels. Which
> is a prerequisite for getting the bugs there fixed with any level
> of promptness, since they can't be fixed until they're noticed.

I agree, we want to use the mainline kernel for omap. Most of the core
omap code is already integrated, now we just need to get few more
omap device drivers integrated to have mainline kernel usable for
most omap boards.

> > Most OMAP
> > platforms build fine, except for one long standing one - the H2 1610
> > defconfig, which hasn't built since 2.6.17-git11.
> Yet oddly enough, that's the only OMAP defconfig present. :(
> Once I2C gets merged, the OSK defconfig could be merged too; and
> that's a much handier board to work with and test. H2 and OSK use
> basically the same OMAP chip (5912 ~= 1610b), but 5912 doesn't need
> NDAs; and the OSK board is is 10x smaller in size and price, plus
> it's available on the open market.

I agree. After the omap I2C driver has been integrated, we should
provide patches for few more omap defconfigs.

> > So, rather than shoveling new stuff in there, can the maintainence of
> > the stuff already merged please be improved.

Sorry, my fault, I've been on vacation for most of July.

> > Build results vs kernel version for H2 1610:
> >
> >
> You'll observe that I recently posted four build fixes (tps65010,
> ohci-omap, omap-rng, smc91x) ... all of which would affect H2... the
> fifth build fix will go to your armlinux patch database soon, it
> addresses the fatal error in that build log. I've already submitted
> patches for the three Kconfig complaints. (By the way, those build
> logs could become more informative by using "make -k" ...)
> Plus H2 is another of the OMAP platforms that can't be fully
> initialized without using I2C. :)

Good to hear the patches mentioned above fix the compile problem :)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at