Re: mm snapshot broken-out-2006-08-02-00-27.tar.gz uploaded

From: Michal Piotrowski
Date: Wed Aug 02 2006 - 17:50:50 EST


Hi Hugh,

On 02/08/06, Hugh Dickins <hugh@xxxxxxxxxxx> wrote:
On Wed, 2 Aug 2006, Michal Piotrowski wrote:
> On 02/08/06, akpm@xxxxxxxx <akpm@xxxxxxxx> wrote:
> > The mm snapshot broken-out-2006-08-02-00-27.tar.gz has been uploaded to
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2006-08-02-00-27.tar.gz
> >
> > It contains the following patches against 2.6.18-rc3:
....
>
> Here is something new, previous mm snapshot was fine
>
> Aug 2 19:56:08 ltg01-fedora kernel: ------------[ cut here ]------------
> Aug 2 19:56:08 ltg01-fedora kernel: kernel BUG at
> /usr/src/linux-work4/mm/shmem.c:1228!
> 1228 BUG_ON(!(vma->vm_flags & VM_CAN_INVALIDATE));
>
> I will revert
> fix-the-race-between-invalidate_inode_pages-and-do_no_page.patch
> fix-the-race-between-invalidate_inode_pages-and-do_no_page-tidy.patch
> and see what will happen.

Rather than reverting those, please add something like (I've not seen
this particular tree) the fixup below - it's easily missed that
ipc/shm.c has its own reference to shmem_nopage. (Last I heard,
the flag was called VM_CAN_INVLD, but it looks like I'm not the
only one averse to unpronounceables.)

Oops is gone. Thanks!

Andrew, can you add this patch to -mm?


Hugh


Regards,
Michal

--
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/