Re: tty_io wtf.

From: Dave Jones
Date: Wed Aug 02 2006 - 18:35:18 EST

On Wed, Aug 02, 2006 at 06:36:04PM -0400, Dave Jones wrote:
> I knew I'd regret digging in the tty code.
> Can someone enlighten me as to what this *should* be doing?
> int tty_insert_flip_string(struct tty_struct *tty, const unsigned char *chars,
> size_t size)
> {
> ....
> /* There is a small chance that we need to split the data over
> several buffers. If this is the case we must loop */
> while (unlikely(size > copied));
> return copied;
> }
> Looping I can understand, but forever ?
> Given we're not advancing 'copied', can we just kill that while loop?
> Or should we be changing it with each iteration?

Disregard, it's the end of a do { } while.
I've been staring at this too long.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at