Re: [PATCH] Create IP100A Driver
From: Jesse Huang
Date: Wed Aug 02 2006 - 22:02:01 EST
I had discuss with our peoples. We decided to use sundance.c to support
IP100A. We will also update some bug fix to this driver.
Thanks for your suggestion.
----- Original Message -----
From: "Jeff Garzik" <jgarzik@xxxxxxxxx>
To: "Jesse Huang" <jesse@xxxxxxxxxxxxx>
Cc: "John W. Linville" <linville@xxxxxxxxxxxxx>;
<linux-kernel@xxxxxxxxxxxxxxx>; <netdev@xxxxxxxxxxxxxxx>; <akpm@xxxxxxxx>
Sent: Friday, July 28, 2006 6:14 PM
Subject: Re: [PATCH] Create IP100A Driver
Although it is occasionally OK to duplicate a driver, I do not see a
compelling case with ip100a.
The stronger case for a single codebase is won on the strengths of lower
long-term maintenance costs, increased strength of review, doesn't break
existing sundance driver uses, and re-use of existing testing benefits.
If you feel strongly about not showing "sundance" to your users, you can
always submit a one-line MODULE_ALIAS() change which permits users to
load "ip100a" (really sundance.c). Using MODULE_ALIAS() seems quite
reasonable, given that IC Plus appears to be taking the lead in future
Sundance-like chip development.
So, please resubmit as changes to the existing sundance.c. This is
better for the standard Linux kernel engineering process.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/