Re: [PATCH] sh: fix proc file removal for superh store queue module

From: Neil Horman
Date: Thu Aug 03 2006 - 16:20:20 EST

Patch to clean up proc file removal in sq module for superh arch. currently on
a failed module load or on module unload a proc file is left registered which
can cause a random memory execution or oopses if read after unload. This patch
cleans up that deregistration.

Thanks & Regards

Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx>

sq.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c
index 781dbb1..4b2b0b1 100644
--- a/arch/sh/kernel/cpu/sh4/sq.c
+++ b/arch/sh/kernel/cpu/sh4/sq.c
@@ -421,18 +421,22 @@ static struct miscdevice sq_dev = {

static int __init sq_api_init(void)
+ int ret;
printk(KERN_NOTICE "sq: Registering store queue API.\n");

create_proc_read_entry("sq_mapping", 0, 0, sq_mapping_read_proc, 0);

- return misc_register(&sq_dev);
+ ret = misc_register(&sq_dev);
+ if (ret)
+ remove_proc_entry("sq_mapping", NULL);
+ return ret;

static void __exit sq_api_exit(void)
+ remove_proc_entry("sq_mapping", NULL);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at