Re: [PATCH] eicon: fix define conflict with ptrace

From: Andrew Morton
Date: Thu Aug 03 2006 - 16:56:55 EST

On Thu, 03 Aug 2006 22:09:59 +0100
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> Ar Gwe, 2006-08-04 am 00:34 +0400, ysgrifennodd Alexey Dobriyan:
> > * MODE_MASK is unused in eicon driver.
> > * Conflicts with a ptrace stuff on arm.
> >
> > drivers/isdn/hardware/eicon/divasync.h:259:1: warning: "MODE_MASK" redefined
> > include2/asm/ptrace.h:48:1: warning: this is the location of the previous definition
> >
> > Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> NAK. You need to fix all the code expecting to use the MODE_MASK with a
> value of 0x00000080

There isn't any (under drivers/isdn, anyway).

I assume Alexey already checked that, but forgot to tell us.

Alexey, your changelogging often tends to be too terse.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at