[PATCH 1/10] hot-add-mem x86_64: acpi motherboard fix

From: Keith Mannthey
Date: Fri Aug 04 2006 - 09:12:32 EST

Is the first of 10 patches. They were built ontop of Kames 6 patches sent out
within the last few days ([RFC][PATCH] fix ioresouce handling take2 [1/5] was
the first). Kames patches fix several real isses and with the 6th patch they
are complete from my point of view.

I have worked to integrate the feedback I recived on the last round of patches
and welcome more ideas/advice. Thanks to everyone who has provied input on
these patches already.

This patch set allow SPARSEMEM and RESERVE based hot-add to work. I have
test both options and they work as expected. I am adding memory to the
2nd node of a numa system (x86_64).

Major changes from last set is the config change and RESERVE enablment.

From: Keith Mannthey <kmannth@xxxxxxxxxx>

Make ACPI motherboard driver not attach to devices/handles it dosen't expect.
Fix a bug where the motherboard driver attached to hot-add memory event and
caused the add memory call to fail.

Signed-off-by: Keith Mannthey<kmannth@xxxxxxxxxx>
motherboard.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletion(-)

diff -urN orig/drivers/acpi/motherboard.c work/drivers/acpi/motherboard.c
--- orig/drivers/acpi/motherboard.c 2006-07-28 13:57:35.000000000 -0400
+++ work/drivers/acpi/motherboard.c 2006-07-28 16:39:22.000000000 -0400
@@ -87,6 +87,7 @@
} else {
/* Memory mapped IO? */
+ return -EINVAL;

if (requested_res)
@@ -96,11 +97,16 @@

static int acpi_motherboard_add(struct acpi_device *device)
+ acpi_status status;
if (!device)
return -EINVAL;
- acpi_walk_resources(device->handle, METHOD_NAME__CRS,
+ status = acpi_walk_resources(device->handle, METHOD_NAME__CRS,
acpi_reserve_io_ranges, NULL);

+ if (ACPI_FAILURE(status))
+ return -ENODEV;
return 0;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/