Re: [Lhms-devel] [PATCH 4/10] hot-add-mem x86_64: Enable SPARSEMEMin srat.c

From: Mika Penttilä
Date: Fri Aug 04 2006 - 11:14:39 EST

Keith Mannthey wrote:
From: Keith Mannthey <kmannth@xxxxxxxxxx>

Enable x86_64 srat.c to share code between both reserve and sparsemem based add memory
paths. Both paths need the hot-add area node locality infomration (nodes_add). This code refactors the code path to allow this.

Signed-off-by: Keith Mannthey<kmannth@xxxxxxxxxx>
Ok nice, but.... hotadd_enough_memory() is broken, it does weird things with nd->start and nd->end which haven't been assigned even values yet. Also, mysterious business with find_e820_area and last_area_end...These areas are not in e820...

And why the reserve_bootmem_node()? Areas not RAM (per e820) are reserved anyways.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at