Re: [PATCH 1/10] hot-add-mem x86_64: acpi motherboard fix

From: KAMEZAWA Hiroyuki
Date: Sat Aug 05 2006 - 01:49:49 EST

On Fri, 4 Aug 2006 07:13:51 -0600
Keith Mannthey <kmannth@xxxxxxxxxx> wrote:
> I have worked to integrate the feedback I recived on the last round of patches
> and welcome more ideas/advice. Thanks to everyone who has provied input on
> these patches already.
Just from review...

If new zone , which was empty at boot, are added into the system.
build_all_zonelists() has to be called. (see online_pages() in memory_hotplug.c)
it looks x86_64's __add_pages() doesn't calles it.

Precisely, look online_pages() (CCONFIG_MEMORY_HOTPLUG_SPARSE)

if (need_zonelists_rebuild)
vm_total_pages = nr_free_pagecache_pages();
These 3 calls are necessary, I think.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at