Re: [PATCH] [MMC] Fix base address configuration in wbsd
From: Pierre Ossman
Date: Sun Aug 06 2006 - 16:55:56 EST
Russell King wrote:
> On Sun, Aug 06, 2006 at 10:22:23PM +0200, Pierre Ossman wrote:
>> There were some confusion about base I/O variables in the wbsd driver.
>> Seems like things have been working on shear luck so far. The global 'io'
>> variable (used when manually configuring the resources) was used instead of
>> the local 'base' variable.
> Applied, thanks.
> Shouldn't "base" be something other than "int" (eg, unsigned long) ?
unsigned short would probably be the right<tm> thing as the resource is
16 bits. I haven't seen it as big enough issue to warrant a patch.
> Also, wbsd_init() takes base, irq, dma but passes wbsd_request_resources
> io, irq and dma? I suspect more fixes are on their way... 8)
And I thought this brown paper bag was just temporary...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/